fix: support including by commit sha over http - #1910
Merged
Conversation
git clone --branch cannot resolve a commit sha, so a 40-hex ref is now fetched explicitly and checked out from FETCH_HEAD.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/parser-includes.ts">
<violation number="1" location="src/parser-includes.ts:380">
P2: The commit SHA regex `/^[0-9a-f]{40}$/` only matches lowercase hex, so an uppercase commit SHA fails detection and falls back to the `--branch` path that cannot resolve a commit SHA. Add the `i` flag: `/^[0-9a-f]{40}$/i`.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git clone --branchcannot resolve a commit sha, so a project or component include pinned to one always failed to fetch; a 40-hex ref is now fetched explicitly and checked out from FETCH_HEAD. Fixes #1800.Summary by cubic
Includes pinned to a commit SHA over HTTP work; we detect 40‑char SHAs case‑insensitively, skip
git clone --branch, fetch the commit, and checkoutFETCH_HEAD, with an integration test. Fixes #1800.Written for commit b0997ef. Summary will update on new commits.